Skip to content

fix(emoji): turn Emoji.is_* properties into methods#1397

Merged
onerandomusername merged 3 commits intomasterfrom
fix/app-emojis
Sep 25, 2025
Merged

fix(emoji): turn Emoji.is_* properties into methods#1397
onerandomusername merged 3 commits intomasterfrom
fix/app-emojis

Conversation

@shiftinv
Copy link
Member

@shiftinv shiftinv commented Sep 22, 2025

Summary

Runtime changes split from #1388. These changes are for consistency with other existing code:

  • is_app_emoji and is_guild_emoji are now methods instead of properties
  • Non-route parameters to HTTPClient methods are now kwarg-only

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running uv run nox -s lint
    • I have type-checked the code by running uv run nox -s pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added this to the disnake v2.12 milestone Sep 22, 2025
@shiftinv shiftinv mentioned this pull request Sep 22, 2025
Merged
8 tasks
@read-the-docs-community
Copy link

read-the-docs-community bot commented Sep 22, 2025 •
edited
Loading

Documentation build overview

📚 disnake | 🛠️ Build #29726363 | 📁 Comparing d380873 against latest (eff6ca6)


🔍 Preview build

Show files changed (49 files in total): 📝 49 modified | ➕ 0 added | ➖ 0 deleted
File Status
genindex.html 📝 modified
index.html 📝 modified
whats_new.html 📝 modified
api/abc.html 📝 modified
api/activities.html 📝 modified
api/app_commands.html 📝 modified
api/app_info.html 📝 modified
api/audit_logs.html 📝 modified
api/automod.html 📝 modified
api/channels.html 📝 modified
api/clients.html 📝 modified
api/components.html 📝 modified
api/emoji.html 📝 modified
api/entitlements.html 📝 modified
api/events.html 📝 modified
api/exceptions.html 📝 modified
api/guild_scheduled_events.html 📝 modified
api/guilds.html 📝 modified
api/integrations.html 📝 modified
api/interactions.html 📝 modified
api/invites.html 📝 modified
api/localization.html 📝 modified
api/members.html 📝 modified
api/messages.html 📝 modified
api/misc.html 📝 modified
api/permissions.html 📝 modified
api/roles.html 📝 modified
api/skus.html 📝 modified
api/soundboard.html 📝 modified
api/stage_instances.html 📝 modified
api/stickers.html 📝 modified
api/subscriptions.html 📝 modified
api/ui.html 📝 modified
api/users.html 📝 modified
api/utilities.html 📝 modified
api/voice.html 📝 modified
api/webhooks.html 📝 modified
api/widgets.html 📝 modified
ext/tasks/index.html 📝 modified
ext/commands/api/app_commands.html 📝 modified
ext/commands/api/bots.html 📝 modified
ext/commands/api/checks.html 📝 modified
ext/commands/api/cogs.html 📝 modified
ext/commands/api/context.html 📝 modified
ext/commands/api/converters.html 📝 modified
ext/commands/api/exceptions.html 📝 modified
ext/commands/api/help_commands.html 📝 modified
ext/commands/api/misc.html 📝 modified
ext/commands/api/prefix_commands.html 📝 modified

Base automatically changed from misc/app-emojis to master September 23, 2025 18:02
@shiftinv shiftinv marked this pull request as ready for review September 23, 2025 19:39
shiftinv
shiftinv commented Sep 23, 2025
View reviewed changes
@onerandomusername onerandomusername enabled auto-merge (squash) September 25, 2025 23:24
@onerandomusername onerandomusername mentioned this pull request Sep 25, 2025
Closed
@onerandomusername onerandomusername merged commit a4b2bf6 into master Sep 25, 2025
33 checks passed
@onerandomusername onerandomusername deleted the fix/app-emojis branch September 25, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@onerandomusername onerandomusername onerandomusername approved these changes

Assignees

No one assigned

Labels

t: bugfix

Projects

None yet

Milestone

disnake v2.12

Development

Successfully merging this pull request may close these issues.

2 participants

@shiftinv @onerandomusername